Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNS support for wallet #15617

Merged
merged 4 commits into from
Nov 9, 2022
Merged

SNS support for wallet #15617

merged 4 commits into from
Nov 9, 2022

Conversation

supermassive
Copy link
Collaborator

@supermassive supermassive commented Oct 24, 2022 •
edited
Loading

Resolves brave/brave-browser#25907

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Run with --enable-features=BraveWalletSns
By now works correctly with https://solana-api.projectserum.com/ set as Solana rpc endpoint. Default https://mainnet-beta-solana.brave.com/rpc endpoint will get SNS support soon.
For Solana network in wallet's send to input
onybose.sol resolves to 5wytVPbjLb2VCXbynhUQabEZZD2B6Wxrkvwm6v6Cuy5X (SOL record on domain)
brave.onybose.sol resolves to 3nCNLXJw9FEXgByDLffv2mC9233EdFHnoJx2MySRrhuR (SOL record on subdomain)
bonfida.sol resolves to HKKp49qGWXd639QsuH7JiLijfVW5UtCVY4s1n2HANwEA (NFT domain)

@supermassive supermassive requested a review from a team as a code owner October 24, 2022 10:52
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Oct 24, 2022
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@supermassive supermassive force-pushed the sns_support branch 2 times, most recently from e3afbfb to 823a64a Compare October 25, 2022 07:42
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@supermassive supermassive force-pushed the sns_support branch 2 times, most recently from d02f33b to e0ab788 Compare October 28, 2022 09:53
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@supermassive supermassive force-pushed the sns_support branch 2 times, most recently from b5a22c2 to b770a13 Compare October 28, 2022 11:17
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@supermassive supermassive force-pushed the sns_support branch 2 times, most recently from 98757a1 to 47f448f Compare October 31, 2022 10:29
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@supermassive supermassive requested review from a team as code owners November 1, 2022 08:24
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

onyb
onyb approved these changes Nov 1, 2022
View reviewed changes
Copy link
Member

@onyb onyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Frontend ++

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@supermassive supermassive requested a review from yrliou November 2, 2022 04:59
yrliou
yrliou reviewed Nov 7, 2022
View reviewed changes
Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take another look at tests this afternoon.

components/brave_wallet/common/brave_wallet.mojom Outdated Show resolved Hide resolved
components/brave_wallet/browser/sns_resolver_task.cc Show resolved Hide resolved
components/brave_wallet/browser/sns_resolver_task.cc Outdated Show resolved Hide resolved
components/brave_wallet/browser/sns_resolver_task.cc Show resolved Hide resolved
components/brave_wallet/browser/sns_resolver_task.cc Outdated Show resolved Hide resolved
components/brave_wallet/browser/sns_resolver_task.cc Outdated Show resolved Hide resolved
components/brave_wallet/browser/sns_resolver_task.cc Outdated Show resolved Hide resolved
components/brave_wallet/browser/sns_resolver_task.cc Outdated Show resolved Hide resolved
components/brave_wallet/browser/sns_resolver_task.cc Outdated Show resolved Hide resolved
components/brave_wallet/browser/sns_resolver_task.cc Outdated Show resolved Hide resolved
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@yrliou
Copy link
Member

yrliou commented Nov 8, 2022

Please create and link an issue, and fill out the test plan, thanks.

yrliou
yrliou approved these changes Nov 9, 2022
View reviewed changes
Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, please create and link an issue, and fill the test plan before merging, thanks.

@supermassive supermassive changed the title SNS support SNS support for wallet Nov 9, 2022
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@supermassive supermassive merged commit a9828ac into master Nov 9, 2022
@supermassive supermassive deleted the sns_support branch November 9, 2022 04:54
@github-actions github-actions bot added this to the 1.47.x - Nightly milestone Nov 9, 2022
@srirambv srirambv mentioned this pull request Jan 9, 2023
Closed
@yrliou yrliou mentioned this pull request Feb 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yrliou yrliou yrliou approved these changes

@onyb onyb onyb approved these changes

Assignees

@supermassive supermassive

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
1.47.x - Release
Development

Successfully merging this pull request may close these issues.

Integrate SNS into Brave wallet to allow users send tokens via .sol domains directly
4 participants
@supermassive @brave-builds @yrliou @onyb